From dab510c546b43f7bf8c8aea8e50141f0fcc0bda0 Mon Sep 17 00:00:00 2001
From: Lorenzo Blasa <lblasa@fb.com>
Date: Thu, 25 Aug 2022 02:18:40 -0700
Subject: [PATCH] Fix starting screen captures

Summary:
Starting a screencapture longer than 30 seconds would timeout as the start command waits for the process to finish. Removed that wait is it is the stop command that should only wait for the finish.

(n.b. please ship after accepting, as I'm on PTO)

Reviewed By: LukeDefeo

Differential Revision: D38918570

fbshipit-source-id: fd93e1239985c81a2143ceb79312518e7ebb27f5
---
 .../flipper-server-core/src/devices/android/AndroidDevice.tsx  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/desktop/flipper-server-core/src/devices/android/AndroidDevice.tsx b/desktop/flipper-server-core/src/devices/android/AndroidDevice.tsx
index 163ef0d64..d3bc7431d 100644
--- a/desktop/flipper-server-core/src/devices/android/AndroidDevice.tsx
+++ b/desktop/flipper-server-core/src/devices/android/AndroidDevice.tsx
@@ -250,8 +250,7 @@ export default class AndroidDevice extends ServerDevice {
           }),
       )
       .then((_) => destination);
-
-    return this.recordingProcess.then((_) => {});
+    // Intentionally not return a promise, this just kicks off the recording!
   }
 
   async stopScreenCapture(): Promise<string> {