Do not overload send as this causes issues with folly::dynamic
Summary: folly::dynamic, std::string, implicit constructors and method overloading is not a good combination. This renames the send method to sendRaw as to avoid issues with existing plugins currently sending string params. Reviewed By: mweststrate Differential Revision: D38827539 fbshipit-source-id: 653f62e41ebfbe93d1af25f39c81f6b05bf84cb4
This commit is contained in:
committed by
Facebook GitHub Bot
parent
92d1f7b77a
commit
d1c06c9c46
@@ -40,7 +40,7 @@ class FlipperConnectionManagerMock : public FlipperConnectionManager {
|
||||
messages.push_back(message);
|
||||
}
|
||||
|
||||
void sendMessage(const std::string& message) override {
|
||||
void sendMessageRaw(const std::string& message) override {
|
||||
messages.push_back(folly::parseJson(message));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user