Do not overload send as this causes issues with folly::dynamic
Summary: folly::dynamic, std::string, implicit constructors and method overloading is not a good combination. This renames the send method to sendRaw as to avoid issues with existing plugins currently sending string params. Reviewed By: mweststrate Differential Revision: D38827539 fbshipit-source-id: 653f62e41ebfbe93d1af25f39c81f6b05bf84cb4
This commit is contained in:
committed by
Facebook GitHub Bot
parent
92d1f7b77a
commit
d1c06c9c46
@@ -524,7 +524,7 @@ class JFlipperConnectionImpl
|
||||
}
|
||||
|
||||
void sendString(const std::string method, const std::string params) {
|
||||
_connection->send(std::move(method), std::move(params));
|
||||
_connection->sendRaw(std::move(method), std::move(params));
|
||||
}
|
||||
|
||||
void sendObject(
|
||||
|
||||
Reference in New Issue
Block a user