jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Internal Xcode install instruction

Browse Source 
Reviewed By: elboman

Differential Revision: D51257660

fbshipit-source-id: 6cf213135f1070def3e62e936d6147b15749b7de
This commit is contained in:
Anton Kastritskiy
2023-11-13 08:26:13 -08:00
committed by Facebook GitHub Bot
parent 9dea899701
commit cb485613e4
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/doctor/src/index.tsx
View File

@@ -148,7 +148,7 @@ export function getHealthchecks(): FlipperDoctor.Healthchecks {
run: async (e: FlipperDoctor.EnvironmentInfo) => { run: async (e: FlipperDoctor.EnvironmentInfo) => {
const hasProblem = e.IDEs == null || e.IDEs.Xcode == null; const hasProblem = e.IDEs == null || e.IDEs.Xcode == null;
const message = hasProblem const message = hasProblem
? `Xcode is not installed. ${installXcode}.` ? `Xcode is not installed.\n${installXcode}.`
: `Xcode version ${e.IDEs.Xcode.version} is installed at "${e.IDEs.Xcode.path}".`; : `Xcode version ${e.IDEs.Xcode.version} is installed at "${e.IDEs.Xcode.path}".`;
return { return {
hasProblem, hasProblem,

6
desktop/flipper-ui-core/src/sandy-chrome/SetupDoctorScreen.tsx
View File

@@ -133,7 +133,11 @@ function CollapsableCategory(props: {
key={check.key} key={check.key}
header={check.label} header={check.label}
extra={<CheckIcon status={check.result.status} />}> extra={<CheckIcon status={check.result.status} />}>
<Paragraph>{check.result.message}</Paragraph> {check.result.message?.split('\n').map((line, index) => (
<Paragraph key={index} style={{marginBottom: 0}}>
{line}
</Paragraph>
))}
{check.result.commands && ( {check.result.commands && (
<List> <List>
{check.result.commands.map(({title, command}, i) => ( {check.result.commands.map(({title, command}, i) => (