From cb485613e45cb03508ba378938d5faea24a7cb24 Mon Sep 17 00:00:00 2001 From: Anton Kastritskiy Date: Mon, 13 Nov 2023 08:26:13 -0800 Subject: [PATCH] Internal Xcode install instruction Reviewed By: elboman Differential Revision: D51257660 fbshipit-source-id: 6cf213135f1070def3e62e936d6147b15749b7de --- desktop/doctor/src/index.tsx | 2 +- .../flipper-ui-core/src/sandy-chrome/SetupDoctorScreen.tsx | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/desktop/doctor/src/index.tsx b/desktop/doctor/src/index.tsx index f02f59dcc..dc5244a6f 100644 --- a/desktop/doctor/src/index.tsx +++ b/desktop/doctor/src/index.tsx @@ -148,7 +148,7 @@ export function getHealthchecks(): FlipperDoctor.Healthchecks { run: async (e: FlipperDoctor.EnvironmentInfo) => { const hasProblem = e.IDEs == null || e.IDEs.Xcode == null; const message = hasProblem - ? `Xcode is not installed. ${installXcode}.` + ? `Xcode is not installed.\n${installXcode}.` : `Xcode version ${e.IDEs.Xcode.version} is installed at "${e.IDEs.Xcode.path}".`; return { hasProblem, diff --git a/desktop/flipper-ui-core/src/sandy-chrome/SetupDoctorScreen.tsx b/desktop/flipper-ui-core/src/sandy-chrome/SetupDoctorScreen.tsx index 552a7329e..569839f90 100644 --- a/desktop/flipper-ui-core/src/sandy-chrome/SetupDoctorScreen.tsx +++ b/desktop/flipper-ui-core/src/sandy-chrome/SetupDoctorScreen.tsx @@ -133,7 +133,11 @@ function CollapsableCategory(props: { key={check.key} header={check.label} extra={}> - {check.result.message} + {check.result.message?.split('\n').map((line, index) => ( + + {line} + + ))} {check.result.commands && ( {check.result.commands.map(({title, command}, i) => (