jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ignoring errors from "send"

Browse Source 
Summary: "send" returns "void" which means we do not care about the execution result, including errors

Reviewed By: lblasa

Differential Revision: D47398015

fbshipit-source-id: ef185575f6e91d69356ab88c7f3d213033759da8
This commit is contained in:
Andrey Goncharov
2023-07-13 03:23:56 -07:00
committed by Facebook GitHub Bot
parent f59a2e5fba
commit ca009d1233
3 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
desktop/flipper-frontend-core/src/AbstractClient.tsx
View File

@@ -230,9 +230,6 @@ export default abstract class AbstractClient extends EventEmitter {
// diff the background plugin list, disconnect old, connect new ones // diff the background plugin list, disconnect old, connect new ones
oldBackgroundPlugins.forEach((plugin) => { oldBackgroundPlugins.forEach((plugin) => {
if (!this.backgroundPlugins.has(plugin)) { if (!this.backgroundPlugins.has(plugin)) {
if (plugin === 'Msys') {
console.log('AbstyractClient.refreshPlugins -> deinit Msys');
}
this.deinitPlugin(plugin); this.deinitPlugin(plugin);
} }
}); });

4
desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx
View File

@@ -324,7 +324,9 @@ export async function handleClientConnected(
query, query,
{ {
send(data: any) { send(data: any) {
server.exec('client-request', id, data); server.exec('client-request', id, data).catch((e) => {
console.warn(e);
});
}, },
async sendExpectResponse(data: any) { async sendExpectResponse(data: any) {
return await server.exec('client-request-response', id, data); return await server.exec('client-request-response', id, data);

4
desktop/flipper-ui-core/src/dispatcher/pluginManager.tsx
View File

@@ -368,10 +368,6 @@ function stopPlugin(
!defaultEnabledBackgroundPlugins.includes(pluginId)) && !defaultEnabledBackgroundPlugins.includes(pluginId)) &&
client?.isBackgroundPlugin(pluginId) client?.isBackgroundPlugin(pluginId)
) { ) {
// Debugging T141716711
if (pluginId === 'Msys') {
console.log('pluginManager.stopPlugin -> deinit Msys');
}
client.deinitPlugin(pluginId); client.deinitPlugin(pluginId);
} }
// stop sandy plugins // stop sandy plugins