From ca009d1233640331986c01042cecceaf9487e7dd Mon Sep 17 00:00:00 2001
From: Andrey Goncharov <aigoncharov@meta.com>
Date: Thu, 13 Jul 2023 03:23:56 -0700
Subject: [PATCH] Ignoring errors from "send"

Summary: "send" returns "void" which means we do not care about the execution result, including errors

Reviewed By: lblasa

Differential Revision: D47398015

fbshipit-source-id: ef185575f6e91d69356ab88c7f3d213033759da8
---
 desktop/flipper-frontend-core/src/AbstractClient.tsx     | 3 ---
 desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx | 4 +++-
 desktop/flipper-ui-core/src/dispatcher/pluginManager.tsx | 4 ----
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/desktop/flipper-frontend-core/src/AbstractClient.tsx b/desktop/flipper-frontend-core/src/AbstractClient.tsx
index fd0636a6f..75d717918 100644
--- a/desktop/flipper-frontend-core/src/AbstractClient.tsx
+++ b/desktop/flipper-frontend-core/src/AbstractClient.tsx
@@ -230,9 +230,6 @@ export default abstract class AbstractClient extends EventEmitter {
     // diff the background plugin list, disconnect old, connect new ones
     oldBackgroundPlugins.forEach((plugin) => {
       if (!this.backgroundPlugins.has(plugin)) {
-        if (plugin === 'Msys') {
-          console.log('AbstyractClient.refreshPlugins -> deinit Msys');
-        }
         this.deinitPlugin(plugin);
       }
     });
diff --git a/desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx b/desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx
index fd7f6254b..51db4320e 100644
--- a/desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx
+++ b/desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx
@@ -324,7 +324,9 @@ export async function handleClientConnected(
     query,
     {
       send(data: any) {
-        server.exec('client-request', id, data);
+        server.exec('client-request', id, data).catch((e) => {
+          console.warn(e);
+        });
       },
       async sendExpectResponse(data: any) {
         return await server.exec('client-request-response', id, data);
diff --git a/desktop/flipper-ui-core/src/dispatcher/pluginManager.tsx b/desktop/flipper-ui-core/src/dispatcher/pluginManager.tsx
index 865eb3708..1b1ea2ed3 100644
--- a/desktop/flipper-ui-core/src/dispatcher/pluginManager.tsx
+++ b/desktop/flipper-ui-core/src/dispatcher/pluginManager.tsx
@@ -368,10 +368,6 @@ function stopPlugin(
       !defaultEnabledBackgroundPlugins.includes(pluginId)) &&
     client?.isBackgroundPlugin(pluginId)
   ) {
-    // Debugging T141716711
-    if (pluginId === 'Msys') {
-      console.log('pluginManager.stopPlugin -> deinit Msys');
-    }
     client.deinitPlugin(pluginId);
   }
   // stop sandy plugins