jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ignore null key in shared preferences (#2146)

Browse Source 
Summary:
SharedPreferences plugin will crash when null key fields in shared preference on Android. Null keys should be ignored.

Fixes https://github.com/facebook/flipper/issues/2078

## Changelog

- Ignore null keys in shared preferences.

Pull Request resolved: https://github.com/facebook/flipper/pull/2146

Reviewed By: mweststrate

Differential Revision: D27522356

Pulled By: passy

fbshipit-source-id: b946cd9ba2a3131b3ffab65e8949fda20a3630fc
This commit is contained in:
bruce3x
2021-04-07 05:13:52 -07:00
committed by Facebook GitHub Bot
parent c9b6f6c7d9
commit c946309f6a
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
android/src/main/java/com/facebook/flipper/plugins/sharedpreferences/SharedPreferencesFlipperPlugin.java
View File

@@ -162,6 +162,8 @@ public class SharedPreferencesFlipperPlugin implements FlipperPlugin {
FlipperObject.Builder builder = new FlipperObject.Builder(); FlipperObject.Builder builder = new FlipperObject.Builder();
Map<String, ?> map = sharedPreferences.getAll(); Map<String, ?> map = sharedPreferences.getAll();
for (Map.Entry<String, ?> entry : map.entrySet()) { for (Map.Entry<String, ?> entry : map.entrySet()) {
final String key = entry.getKey();
if (key == null) continue;
final Object val = entry.getValue(); final Object val = entry.getValue();
builder.put(entry.getKey(), val); builder.put(entry.getKey(), val);
} }