From c946309f6aafa0346a61583db93cf0526439598f Mon Sep 17 00:00:00 2001 From: bruce3x Date: Wed, 7 Apr 2021 05:13:52 -0700 Subject: [PATCH] Ignore null key in shared preferences (#2146) Summary: SharedPreferences plugin will crash when null key fields in shared preference on Android. Null keys should be ignored. Fixes https://github.com/facebook/flipper/issues/2078 ## Changelog - Ignore null keys in shared preferences. Pull Request resolved: https://github.com/facebook/flipper/pull/2146 Reviewed By: mweststrate Differential Revision: D27522356 Pulled By: passy fbshipit-source-id: b946cd9ba2a3131b3ffab65e8949fda20a3630fc --- .../sharedpreferences/SharedPreferencesFlipperPlugin.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/android/src/main/java/com/facebook/flipper/plugins/sharedpreferences/SharedPreferencesFlipperPlugin.java b/android/src/main/java/com/facebook/flipper/plugins/sharedpreferences/SharedPreferencesFlipperPlugin.java index e46f7772d..e3e7222df 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/sharedpreferences/SharedPreferencesFlipperPlugin.java +++ b/android/src/main/java/com/facebook/flipper/plugins/sharedpreferences/SharedPreferencesFlipperPlugin.java @@ -162,6 +162,8 @@ public class SharedPreferencesFlipperPlugin implements FlipperPlugin { FlipperObject.Builder builder = new FlipperObject.Builder(); Map map = sharedPreferences.getAll(); for (Map.Entry entry : map.entrySet()) { + final String key = entry.getKey(); + if (key == null) continue; final Object val = entry.getValue(); builder.put(entry.getKey(), val); }