jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Log unable to extract clientQuery as warning instead of error

Browse Source 
Summary:
^
LogView is raising this up but I don't think there's an actionable item from our side. If a client doesn't have the right arguments on the query string then we effectively are unable to construct a valid query.

All our clients do this correctly, but there may be instances that either a browser or another process is 'trying' to connect to Flipper even if unintentionally. This behaviour I've observed in the past.

Changelog: Log 'Unable to extract the client query from the request URL' as warning

Reviewed By: passy

Differential Revision: D34340068

fbshipit-source-id: f5fc36a9803a83d6662b6383589bc0aa99774798
This commit is contained in:
Lorenzo Blasa
2022-02-18 05:49:02 -08:00
committed by Facebook GitHub Bot
parent db68ff5b3a
commit c45164ec2b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/flipper-server-core/src/comms/ServerWebSocket.tsx
View File

@@ -182,7 +182,7 @@ class ServerWebSocket extends ServerAdapter {
const clientQuery = this.parseClientQuery(query);
if (!clientQuery) {
console.error(
console.warn(
'[conn] Unable to extract the client query from the request URL.',
);
throw new Error(