From c45164ec2bad617981ee1a8096326a76b3807102 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Fri, 18 Feb 2022 05:49:02 -0800 Subject: [PATCH] Log unable to extract clientQuery as warning instead of error Summary: ^ LogView is raising this up but I don't think there's an actionable item from our side. If a client doesn't have the right arguments on the query string then we effectively are unable to construct a valid query. All our clients do this correctly, but there may be instances that either a browser or another process is 'trying' to connect to Flipper even if unintentionally. This behaviour I've observed in the past. Changelog: Log 'Unable to extract the client query from the request URL' as warning Reviewed By: passy Differential Revision: D34340068 fbshipit-source-id: f5fc36a9803a83d6662b6383589bc0aa99774798 --- desktop/flipper-server-core/src/comms/ServerWebSocket.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop/flipper-server-core/src/comms/ServerWebSocket.tsx b/desktop/flipper-server-core/src/comms/ServerWebSocket.tsx index 93f8df822..94cdf4d93 100644 --- a/desktop/flipper-server-core/src/comms/ServerWebSocket.tsx +++ b/desktop/flipper-server-core/src/comms/ServerWebSocket.tsx @@ -182,7 +182,7 @@ class ServerWebSocket extends ServerAdapter { const clientQuery = this.parseClientQuery(query); if (!clientQuery) { - console.error( + console.warn( '[conn] Unable to extract the client query from the request URL.', ); throw new Error(