Fix showing plugins that are incompatible with client

Summary: Fix an issue where we accidentally show all plugins for all clients, causing client crashes if an unsupported plugin is selected

Reviewed By: jknoxville

Differential Revision: D18347907

fbshipit-source-id: 5416f29b8eae2daed64869380f9e9382e90261d7

src/chrome/MainSidebar.tsx

@@ -472,7 +472,9 @@ class MainSidebar extends PureComponent<Props, State> {
         selectedPlugin: plugin,
       });
     };
-    const allPlugins = Array.from(this.props.clientPlugins.values());
+    const allPlugins = Array.from(this.props.clientPlugins.values()).filter(
+      (p: typeof FlipperPlugin) => client.plugins.indexOf(p.id) > -1,
+    );
     const favoritePlugins: FlipperPlugins = getFavoritePlugins(
       client,
       allPlugins,