From c3402da4674ca2c7c553655dca82efe0cd18040b Mon Sep 17 00:00:00 2001
From: Michel Weststrate <mweststrate@fb.com>
Date: Wed, 6 Nov 2019 07:27:49 -0800
Subject: [PATCH] Fix showing plugins that are incompatible with client

Summary: Fix an issue where we accidentally show all plugins for all clients, causing client crashes if an unsupported plugin is selected

Reviewed By: jknoxville

Differential Revision: D18347907

fbshipit-source-id: 5416f29b8eae2daed64869380f9e9382e90261d7
---
 src/chrome/MainSidebar.tsx | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/chrome/MainSidebar.tsx b/src/chrome/MainSidebar.tsx
index 18cc14e1e..0bb017f8d 100644
--- a/src/chrome/MainSidebar.tsx
+++ b/src/chrome/MainSidebar.tsx
@@ -472,7 +472,9 @@ class MainSidebar extends PureComponent<Props, State> {
         selectedPlugin: plugin,
       });
     };
-    const allPlugins = Array.from(this.props.clientPlugins.values());
+    const allPlugins = Array.from(this.props.clientPlugins.values()).filter(
+      (p: typeof FlipperPlugin) => client.plugins.indexOf(p.id) > -1,
+    );
     const favoritePlugins: FlipperPlugins = getFavoritePlugins(
       client,
       allPlugins,