jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix excessive error login for FLIPPER_BROWSER_PORT

Browse Source 
Summary: Prior to this diff, an empty env var FLIPPER_BROWSER_PORT resulted in an error

Reviewed By: passy

Differential Revision: D33712720

fbshipit-source-id: 760fc92bbf44268ec428a3d2947735d5cf8567b7
This commit is contained in:
Andrey Goncharov
2022-01-21 13:27:22 -08:00
committed by Facebook GitHub Bot
parent 76a9b3d3ae
commit b5cd33f7e8
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
desktop/flipper-server-core/src/FlipperServerConfig.tsx
View File

@@ -63,16 +63,19 @@ export function getServerPortsConfig(): {
} }
} }
const portBrowserOverride = parseEnvironmentVariableAsNumber( let portBrowserOverride: number | undefined;
if (process.env.FLIPPER_BROWSER_PORT) {
portBrowserOverride = parseEnvironmentVariableAsNumber(
'FLIPPER_BROWSER_PORT', 'FLIPPER_BROWSER_PORT',
); );
if (portBrowserOverride === undefined) { if (!portBrowserOverride) {
console.error( console.error(
`Ignoring malformed FLIPPER_BROWSER_PORT env variable: `Ignoring malformed FLIPPER_BROWSER_PORT env variable:
"${process.env.FLIPPER_BROWSER_PORT || ''}". "${process.env.FLIPPER_BROWSER_PORT || ''}".
Example expected format: "1111".`, Example expected format: "1111".`,
); );
} }
}
return { return {
serverPorts: portOverrides ?? { serverPorts: portOverrides ?? {