From b5cd33f7e86d77ccf599f8769f3a725a05b6a106 Mon Sep 17 00:00:00 2001
From: Andrey Goncharov <aigoncharov@fb.com>
Date: Fri, 21 Jan 2022 13:27:22 -0800
Subject: [PATCH] Fix excessive error login for FLIPPER_BROWSER_PORT

Summary: Prior to this diff, an empty env var FLIPPER_BROWSER_PORT resulted in an error

Reviewed By: passy

Differential Revision: D33712720

fbshipit-source-id: 760fc92bbf44268ec428a3d2947735d5cf8567b7
---
 .../src/FlipperServerConfig.tsx                 | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/desktop/flipper-server-core/src/FlipperServerConfig.tsx b/desktop/flipper-server-core/src/FlipperServerConfig.tsx
index 11af7aa97..1162f7bfa 100644
--- a/desktop/flipper-server-core/src/FlipperServerConfig.tsx
+++ b/desktop/flipper-server-core/src/FlipperServerConfig.tsx
@@ -63,15 +63,18 @@ export function getServerPortsConfig(): {
     }
   }
 
-  const portBrowserOverride = parseEnvironmentVariableAsNumber(
-    'FLIPPER_BROWSER_PORT',
-  );
-  if (portBrowserOverride === undefined) {
-    console.error(
-      `Ignoring malformed FLIPPER_BROWSER_PORT env variable:
+  let portBrowserOverride: number | undefined;
+  if (process.env.FLIPPER_BROWSER_PORT) {
+    portBrowserOverride = parseEnvironmentVariableAsNumber(
+      'FLIPPER_BROWSER_PORT',
+    );
+    if (!portBrowserOverride) {
+      console.error(
+        `Ignoring malformed FLIPPER_BROWSER_PORT env variable:
           "${process.env.FLIPPER_BROWSER_PORT || ''}".
           Example expected format: "1111".`,
-    );
+      );
+    }
   }
 
   return {