jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Updated the installation instruction for swift projects with use_framework

Browse Source 
Summary: As per the title. This diff tackles the installation issue for swift projects with `use_framework!`. For more information on this bug follow the discussion [here](https://github.com/facebook/flipper/issues/254)

Reviewed By: danielbuechele

Differential Revision: D15198527

fbshipit-source-id: 573d328369d4bf566ed89f707ed2d6902da0443a
This commit is contained in:
Pritesh Nandgaonkar
2019-05-03 09:48:20 -07:00
committed by Facebook Github Bot
parent c866ba9428
commit a8e7f0e028
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
docs/getting-started.md
View File

@@ -157,19 +157,21 @@ target 'MyApp' do
# it's dependencies to be static and all other pods to # it's dependencies to be static and all other pods to
# be dynamic. # be dynamic.
# $static_framework = ['FlipperKit', 'Flipper', 'Folly', # $static_framework = ['FlipperKit', 'Flipper', 'Flipper-Folly',
# 'CocoaAsyncSocket', 'ComponentKit', 'DoubleConversion', # 'CocoaAsyncSocket', 'ComponentKit', 'DoubleConversion',
# 'glog', 'PeerTalk', 'RSocket', 'Yoga', 'YogaKit', # 'glog', 'Flipper-PeerTalk', 'Flipper-RSocket', 'Yoga', 'YogaKit',
# 'CocoaLibEvent', 'OpenSSL-Static', 'boost-for-react-native'] # 'CocoaLibEvent', 'OpenSSL-Static', 'boost-for-react-native']
#
# pre_install do |installer| # pre_install do |installer|
# installer.pod_targets.each do |pod| # Pod::Installer::Xcode::TargetValidator.send(:define_method, :verify_no_static_framework_transitive_dependencies) {}
# if $static_framework.include?(pod.name) # installer.pod_targets.each do |pod|
# pod.host_requires_frameworks = false # if $static_framework.include?(pod.name)
# end # pod.instance_variable_set(:@host_requires_frameworks, false)
# end
# end # end
# end # end
# This post_install hook adds the -DFB_SONARKIT_ENABLED flag to OTHER_SWIFT_FLAGS, necessary to build swift target # This post_install hook adds the -DFB_SONARKIT_ENABLED flag to OTHER_SWIFT_FLAGS, necessary to build swift target
post_install do |installer| post_install do |installer|
file_name = Dir.glob("*.xcodeproj")[0] file_name = Dir.glob("*.xcodeproj")[0]