From a8e7f0e028df2af1cb662549f4e486e500520daa Mon Sep 17 00:00:00 2001 From: Pritesh Nandgaonkar Date: Fri, 3 May 2019 09:48:20 -0700 Subject: [PATCH] Updated the installation instruction for swift projects with use_framework Summary: As per the title. This diff tackles the installation issue for swift projects with `use_framework!`. For more information on this bug follow the discussion [here](https://github.com/facebook/flipper/issues/254) Reviewed By: danielbuechele Differential Revision: D15198527 fbshipit-source-id: 573d328369d4bf566ed89f707ed2d6902da0443a --- docs/getting-started.md | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/docs/getting-started.md b/docs/getting-started.md index 28cc35a20..2c0588b70 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -157,19 +157,21 @@ target 'MyApp' do # it's dependencies to be static and all other pods to # be dynamic. - # $static_framework = ['FlipperKit', 'Flipper', 'Folly', + # $static_framework = ['FlipperKit', 'Flipper', 'Flipper-Folly', # 'CocoaAsyncSocket', 'ComponentKit', 'DoubleConversion', - # 'glog', 'PeerTalk', 'RSocket', 'Yoga', 'YogaKit', + # 'glog', 'Flipper-PeerTalk', 'Flipper-RSocket', 'Yoga', 'YogaKit', # 'CocoaLibEvent', 'OpenSSL-Static', 'boost-for-react-native'] - + # # pre_install do |installer| - # installer.pod_targets.each do |pod| - # if $static_framework.include?(pod.name) - # pod.host_requires_frameworks = false - # end + # Pod::Installer::Xcode::TargetValidator.send(:define_method, :verify_no_static_framework_transitive_dependencies) {} + # installer.pod_targets.each do |pod| + # if $static_framework.include?(pod.name) + # pod.instance_variable_set(:@host_requires_frameworks, false) + # end # end # end + # This post_install hook adds the -DFB_SONARKIT_ENABLED flag to OTHER_SWIFT_FLAGS, necessary to build swift target post_install do |installer| file_name = Dir.glob("*.xcodeproj")[0]