jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix plugin success rate logging

Browse Source 
Summary:
I noticed that during a refactor, plugin success-rate failures started getting reported as successes.
Thankfully it's only the plugin metrics that are affected.

Reviewed By: passy

Differential Revision: D15394864

fbshipit-source-id: d9f44a0dd61f68dcdcbf2eb524821a3eb023231b
This commit is contained in:
John Knox
2019-05-28 04:17:24 -07:00
committed by Facebook Github Bot
parent 79a4c3a163
commit a64a2a31e5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/utils/metrics.js
View File

@@ -95,7 +95,7 @@ function logPluginSuccessRate(name: string, plugin: string, result: Result) {
getInstance().track( getInstance().track(
'success-rate', 'success-rate',
name, name,
{value: 1, error: extractMessage(result.error)}, {value: 0, error: extractMessage(result.error)},
plugin, plugin,
); );
} }