From a64a2a31e52aaeec691f3d5e362b32d6aa66fde9 Mon Sep 17 00:00:00 2001 From: John Knox Date: Tue, 28 May 2019 04:17:24 -0700 Subject: [PATCH] Fix plugin success rate logging Summary: I noticed that during a refactor, plugin success-rate failures started getting reported as successes. Thankfully it's only the plugin metrics that are affected. Reviewed By: passy Differential Revision: D15394864 fbshipit-source-id: d9f44a0dd61f68dcdcbf2eb524821a3eb023231b --- src/utils/metrics.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/metrics.js b/src/utils/metrics.js index f076f959d..754d11653 100644 --- a/src/utils/metrics.js +++ b/src/utils/metrics.js @@ -95,7 +95,7 @@ function logPluginSuccessRate(name: string, plugin: string, result: Result) { getInstance().track( 'success-rate', name, - {value: 1, error: extractMessage(result.error)}, + {value: 0, error: extractMessage(result.error)}, plugin, ); }