jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Dont emit mounted drawables for litho

Browse Source 
Summary: Getting the boxes to line up is quite hard to do right and has undetermined value

Reviewed By: mihaelao

Differential Revision: D40430776

fbshipit-source-id: 6093c4874f39ecf0c673407da2bd03ef06ca017e
This commit is contained in:
Luke De Feo
2022-10-25 07:10:38 -07:00
committed by Facebook GitHub Bot
parent 06dbcecfad
commit a0d1013b94
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt
View File

@@ -39,10 +39,10 @@ class DebugComponentDescriptor(val register: DescriptorRegister) : NodeDescripto
*/
result.add(OffsetChild.zero(mountedView, descriptor))
} else if (mountedDrawable != null) {
val descriptor: NodeDescriptor<Any> =
register.descriptorForClassUnsafe(mountedDrawable.javaClass)
// same here
result.add(OffsetChild.zero(mountedDrawable, descriptor))
/**
* don't emit mounted drawables since they are leaf nodes and its somewhat tricky to get the
* wireframe bounds to play nice. Something to address later if there is feedback
*/
} else {
for (child in node.childComponents) {
result.add(child)