From a0d1013b94feec1521ff124e7a987c2efc64a658 Mon Sep 17 00:00:00 2001 From: Luke De Feo Date: Tue, 25 Oct 2022 07:10:38 -0700 Subject: [PATCH] Dont emit mounted drawables for litho Summary: Getting the boxes to line up is quite hard to do right and has undetermined value Reviewed By: mihaelao Differential Revision: D40430776 fbshipit-source-id: 6093c4874f39ecf0c673407da2bd03ef06ca017e --- .../litho/descriptors/DebugComponentDescriptor.kt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt b/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt index 5d78b79e7..cf02d3771 100644 --- a/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt +++ b/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt @@ -39,10 +39,10 @@ class DebugComponentDescriptor(val register: DescriptorRegister) : NodeDescripto */ result.add(OffsetChild.zero(mountedView, descriptor)) } else if (mountedDrawable != null) { - val descriptor: NodeDescriptor = - register.descriptorForClassUnsafe(mountedDrawable.javaClass) - // same here - result.add(OffsetChild.zero(mountedDrawable, descriptor)) + /** + * don't emit mounted drawables since they are leaf nodes and its somewhat tricky to get the + * wireframe bounds to play nice. Something to address later if there is feedback + */ } else { for (child in node.childComponents) { result.add(child)