jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix changelog.md generation

Browse Source 
Summary: Currently Flipper shows empty Changelog with only "pre-history" entry. This is because of path in generation script is wrong now. Flipper shows Changelog.md from desktop/static, so generated entries should be added there rather than to Changelog.md in the root.

Reviewed By: passy

Differential Revision: D21016884

fbshipit-source-id: 8709a2556374ec70bc665eaf0729bb85fd0d913f
This commit is contained in:
Anton Nikolaev
2020-04-14 09:18:00 -07:00
committed by Facebook GitHub Bot
parent f3bb94fd7c
commit a08bed86b7
3 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
CHANGELOG.md
View File

@@ -1,18 +1,3 @@
# 0.37.0 (8/4/2020)
* D20868923 - Fix connections on Android devices with older SDKs (19)
* D20822063 - The QPL plugin now shows qpl start times
* D20836635 - Stabilized QPL plugin to avoid crashes with iOS devices, normalized event times to always report in milliseconds.
# 0.36.0 (3/4/2020)
* D20673166 - New Hermes Debugger plugin for React Native apps.
* D20789712 - Fixed error "SHA-1 for file is not computed" on 3rd party plugin compilation in dev mode (yarn start).
* D20767096 - Fixed an issue where QPL points where not showing up in the marker timeline
* D20724437 - Fixed applying of product attributes (title, publisher etc) to Flipper builds
# Changelog
See [desktop/static/CHANGELOG.md](desktop/static/CHANGELOG.md)

13
desktop/scripts/generate-changelog.js
View File

@@ -5,7 +5,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @noformat
* @format
*/
/**
@@ -19,13 +19,16 @@ const cp = require('child_process');
const desktopRoot = path.resolve(__dirname, '..');
const root = path.resolve(desktopRoot, '..');
const staticDir = path.join(desktopRoot, 'static');
const version = JSON.parse(fs.readFileSync(path.join(desktopRoot, 'package.json'), 'utf8')).version;
const version = JSON.parse(
fs.readFileSync(path.join(desktopRoot, 'package.json'), 'utf8'),
).version;
const now = new Date();
const date = `${now.getDate()}/${now.getMonth() + 1}/${now.getFullYear()}`;
const newlineMarker = '__NEWLINE_MARKER__';
const fChangelog = path.resolve(root, 'CHANGELOG.md');
const fChangelog = path.resolve(staticDir, 'CHANGELOG.md');
const lastCommit = cp
.execSync(`hg log --limit 1 --template '{node}'`, {cwd: root})
@@ -33,12 +36,12 @@ const lastCommit = cp
const firstCommit = cp
.execSync(
`hg log --limit 1 --template '{node}' --keyword 'Flipper Release: v'`,
{cwd: root}
{cwd: root},
)
.toString();
console.log(
`Generating changelog for version ${version} based on ${firstCommit}..${lastCommit}`
`Generating changelog for version ${version} based on ${firstCommit}..${lastCommit}`,
);
// # get all commit summaries since last release | find all changelog entries, but make sure there is only one line per commit by temporarily replacing newlines

15
desktop/static/CHANGELOG.md
View File

@@ -1,3 +1,18 @@
# 0.37.0 (8/4/2020)
* D20868923 - Fix connections on Android devices with older SDKs (19)
* D20822063 - The QPL plugin now shows qpl start times
* D20836635 - Stabilized QPL plugin to avoid crashes with iOS devices, normalized event times to always report in milliseconds.
# 0.36.0 (3/4/2020)
* D20673166 - New Hermes Debugger plugin for React Native apps.
* D20789712 - Fixed error "SHA-1 for file is not computed" on 3rd party plugin compilation in dev mode (yarn start).
* D20767096 - Fixed an issue where QPL points where not showing up in the marker timeline
* D20724437 - Fixed applying of product attributes (title, publisher etc) to Flipper builds
# Pre-history
Please see our [releases GitHub page](https://github.com/facebook/flipper/releases) for a full list of changes of old releases.