Prefix unused vars (#897)

Summary:
Just need a recent diff to run some tests on, tbh.
Pull Request resolved: https://github.com/facebook/flipper/pull/897

Reviewed By: mweststrate

Differential Revision: D20490753

Pulled By: passy

fbshipit-source-id: cb7336becfc694cb99f8d0a70f3bee4b7a639c2a
This commit is contained in:
Pascal Hartig
2020-03-17 11:32:38 -07:00
committed by Facebook GitHub Bot
parent b61d2aff26
commit 9eea885a2d
5 changed files with 17 additions and 19 deletions

View File

@@ -11,8 +11,8 @@ import {Logger} from '../fb-interfaces/Logger';
import {Store} from '../reducers/index'; import {Store} from '../reducers/index';
export default class BugReporter { export default class BugReporter {
constructor(logManager: Logger, store: Store) {} constructor(_logManager: Logger, _store: Store) {}
async report(title: string, body: string): Promise<number> { async report(_title: string, _body: string): Promise<number> {
return Promise.resolve(-1); return Promise.resolve(-1);
} }
} }

View File

@@ -12,7 +12,7 @@
* The recommended way to use this, is to instantiate it inside Logger, * The recommended way to use this, is to instantiate it inside Logger,
* so that all logged errors get reported to this class. * so that all logged errors get reported to this class.
*/ */
export function cleanStack(stack: string, loc?: string) {} export function cleanStack(_stack: string, _loc?: string) {}
import ScribeLogger from './ScribeLogger'; import ScribeLogger from './ScribeLogger';
export type ObjectError = export type ObjectError =
@@ -23,6 +23,6 @@ export type ObjectError =
}; };
export default class ErrorReporter { export default class ErrorReporter {
constructor(scribeLogger: ScribeLogger) {} constructor(_scribeLogger: ScribeLogger) {}
report(err: ObjectError) {} report(_err: ObjectError) {}
} }

View File

@@ -15,6 +15,6 @@ export type ScribeMessage = {
import {Logger} from '../fb-interfaces/Logger'; import {Logger} from '../fb-interfaces/Logger';
export default class ScribeLogger { export default class ScribeLogger {
constructor(logger: Logger) {} constructor(_logger: Logger) {}
send(message: ScribeMessage) {} send(_message: ScribeMessage) {}
} }

View File

@@ -7,8 +7,6 @@
* @format * @format
*/ */
import {Component} from 'react';
export type FeedbackPrompt = { export type FeedbackPrompt = {
preSubmitHeading: string; preSubmitHeading: string;
postSubmitHeading: string; postSubmitHeading: string;
@@ -19,21 +17,21 @@ export type FeedbackPrompt = {
}; };
export async function submitRating( export async function submitRating(
rating: number, _rating: number,
sessionId: string | null, _sessionId: string | null,
): Promise<void> { ): Promise<void> {
throw new Error('Method not implemented.'); throw new Error('Method not implemented.');
} }
export async function submitComment( export async function submitComment(
rating: number, _rating: number,
comment: string, _comment: string,
selectedPredefinedComments: string[], _selectedPredefinedComments: string[],
allowUserInfoSharing: boolean, _allowUserInfoSharing: boolean,
sessionId: string | null, _sessionId: string | null,
): Promise<void> { ): Promise<void> {
throw new Error('Method not implemented.'); throw new Error('Method not implemented.');
} }
export async function dismiss(sessionId: string | null): Promise<void> { export async function dismiss(_sessionId: string | null): Promise<void> {
throw new Error('Method not implemented.'); throw new Error('Method not implemented.');
} }
export async function getPrompt(): Promise<FeedbackPrompt> { export async function getPrompt(): Promise<FeedbackPrompt> {

View File

@@ -8,7 +8,7 @@
*/ */
export default function createPaste( export default function createPaste(
input: string, _input: string,
): Promise<string | undefined> { ): Promise<string | undefined> {
return Promise.reject('Not implemented!'); return Promise.reject(new Error('Not implemented!'));
} }