Prefix unused vars (#897)
Summary: Just need a recent diff to run some tests on, tbh. Pull Request resolved: https://github.com/facebook/flipper/pull/897 Reviewed By: mweststrate Differential Revision: D20490753 Pulled By: passy fbshipit-source-id: cb7336becfc694cb99f8d0a70f3bee4b7a639c2a
This commit is contained in:
committed by
Facebook GitHub Bot
parent
b61d2aff26
commit
9eea885a2d
@@ -11,8 +11,8 @@ import {Logger} from '../fb-interfaces/Logger';
|
||||
import {Store} from '../reducers/index';
|
||||
|
||||
export default class BugReporter {
|
||||
constructor(logManager: Logger, store: Store) {}
|
||||
async report(title: string, body: string): Promise<number> {
|
||||
constructor(_logManager: Logger, _store: Store) {}
|
||||
async report(_title: string, _body: string): Promise<number> {
|
||||
return Promise.resolve(-1);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -12,7 +12,7 @@
|
||||
* The recommended way to use this, is to instantiate it inside Logger,
|
||||
* so that all logged errors get reported to this class.
|
||||
*/
|
||||
export function cleanStack(stack: string, loc?: string) {}
|
||||
export function cleanStack(_stack: string, _loc?: string) {}
|
||||
import ScribeLogger from './ScribeLogger';
|
||||
|
||||
export type ObjectError =
|
||||
@@ -23,6 +23,6 @@ export type ObjectError =
|
||||
};
|
||||
|
||||
export default class ErrorReporter {
|
||||
constructor(scribeLogger: ScribeLogger) {}
|
||||
report(err: ObjectError) {}
|
||||
constructor(_scribeLogger: ScribeLogger) {}
|
||||
report(_err: ObjectError) {}
|
||||
}
|
||||
|
||||
@@ -15,6 +15,6 @@ export type ScribeMessage = {
|
||||
import {Logger} from '../fb-interfaces/Logger';
|
||||
|
||||
export default class ScribeLogger {
|
||||
constructor(logger: Logger) {}
|
||||
send(message: ScribeMessage) {}
|
||||
constructor(_logger: Logger) {}
|
||||
send(_message: ScribeMessage) {}
|
||||
}
|
||||
|
||||
@@ -7,8 +7,6 @@
|
||||
* @format
|
||||
*/
|
||||
|
||||
import {Component} from 'react';
|
||||
|
||||
export type FeedbackPrompt = {
|
||||
preSubmitHeading: string;
|
||||
postSubmitHeading: string;
|
||||
@@ -19,21 +17,21 @@ export type FeedbackPrompt = {
|
||||
};
|
||||
|
||||
export async function submitRating(
|
||||
rating: number,
|
||||
sessionId: string | null,
|
||||
_rating: number,
|
||||
_sessionId: string | null,
|
||||
): Promise<void> {
|
||||
throw new Error('Method not implemented.');
|
||||
}
|
||||
export async function submitComment(
|
||||
rating: number,
|
||||
comment: string,
|
||||
selectedPredefinedComments: string[],
|
||||
allowUserInfoSharing: boolean,
|
||||
sessionId: string | null,
|
||||
_rating: number,
|
||||
_comment: string,
|
||||
_selectedPredefinedComments: string[],
|
||||
_allowUserInfoSharing: boolean,
|
||||
_sessionId: string | null,
|
||||
): Promise<void> {
|
||||
throw new Error('Method not implemented.');
|
||||
}
|
||||
export async function dismiss(sessionId: string | null): Promise<void> {
|
||||
export async function dismiss(_sessionId: string | null): Promise<void> {
|
||||
throw new Error('Method not implemented.');
|
||||
}
|
||||
export async function getPrompt(): Promise<FeedbackPrompt> {
|
||||
|
||||
@@ -8,7 +8,7 @@
|
||||
*/
|
||||
|
||||
export default function createPaste(
|
||||
input: string,
|
||||
_input: string,
|
||||
): Promise<string | undefined> {
|
||||
return Promise.reject('Not implemented!');
|
||||
return Promise.reject(new Error('Not implemented!'));
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user