jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Wraps receiving callback into an autoreleasepool

Browse Source 
Summary: The receiving callbacks are executed from a thread that doesn't have an autorelease pool. That results in autoreleased objects leaking

Reviewed By: schaitoff

Differential Revision: D8889915

fbshipit-source-id: 07e9129954e6f9afea56473b590125c63ecd7092
This commit is contained in:
Diego Sanchez
2018-07-18 08:05:10 -07:00
committed by Facebook Github Bot
parent 818c5e9dc5
commit 9e7c2b6982
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
iOS/SonarKit/CppBridge/SonarCppBridgingConnection.mm
View File

@@ -33,13 +33,15 @@
- (void)receive:(NSString *)method withBlock:(SonarReceiver)receiver - (void)receive:(NSString *)method withBlock:(SonarReceiver)receiver
{ {
const auto lambda = [receiver](const folly::dynamic &message, const auto lambda = [receiver](const folly::dynamic &message,
std::unique_ptr<facebook::sonar::SonarResponder> responder) { std::unique_ptr<facebook::sonar::SonarResponder> responder) {
SonarCppBridgingResponder *const objCResponder = @autoreleasepool {
SonarCppBridgingResponder *const objCResponder =
[[SonarCppBridgingResponder alloc] initWithCppResponder:std::move(responder)]; [[SonarCppBridgingResponder alloc] initWithCppResponder:std::move(responder)];
receiver(facebook::cxxutils::convertFollyDynamicToId(message), objCResponder); receiver(facebook::cxxutils::convertFollyDynamicToId(message), objCResponder);
}; }
conn_->receive([method UTF8String], lambda); };
conn_->receive([method UTF8String], lambda);
} }
@end @end