9e7c2b6982
Summary: The receiving callbacks are executed from a thread that doesn't have an autorelease pool. That results in autoreleased objects leaking Reviewed By: schaitoff Differential Revision: D8889915 fbshipit-source-id: 07e9129954e6f9afea56473b590125c63ecd7092
48 lines
1.3 KiB
Plaintext
48 lines
1.3 KiB
Plaintext
/*
|
|
* Copyright (c) 2018-present, Facebook, Inc.
|
|
*
|
|
* This source code is licensed under the MIT license found in the LICENSE
|
|
* file in the root directory of this source tree.
|
|
*
|
|
*/
|
|
#import "SonarCppBridgingConnection.h"
|
|
|
|
#import <FBCxxUtils/FBCxxFollyDynamicConvert.h>
|
|
|
|
#import "SonarCppBridgingResponder.h"
|
|
|
|
@implementation SonarCppBridgingConnection
|
|
{
|
|
std::shared_ptr<facebook::sonar::SonarConnection> conn_;
|
|
}
|
|
|
|
- (instancetype)initWithCppConnection:(std::shared_ptr<facebook::sonar::SonarConnection>)conn
|
|
{
|
|
if (self = [super init]) {
|
|
conn_ = conn;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
#pragma mark - SonarConnection
|
|
|
|
- (void)send:(NSString *)method withParams:(NSDictionary *)params
|
|
{
|
|
conn_->send([method UTF8String], facebook::cxxutils::convertIdToFollyDynamic(params, true));
|
|
}
|
|
|
|
- (void)receive:(NSString *)method withBlock:(SonarReceiver)receiver
|
|
{
|
|
const auto lambda = [receiver](const folly::dynamic &message,
|
|
std::unique_ptr<facebook::sonar::SonarResponder> responder) {
|
|
@autoreleasepool {
|
|
SonarCppBridgingResponder *const objCResponder =
|
|
[[SonarCppBridgingResponder alloc] initWithCppResponder:std::move(responder)];
|
|
receiver(facebook::cxxutils::convertFollyDynamicToId(message), objCResponder);
|
|
}
|
|
};
|
|
conn_->receive([method UTF8String], lambda);
|
|
}
|
|
|
|
@end
|