jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix issue server-core not cleaning up devices properly

Browse Source 
Summary:
Notice during debugging that devices keep unregistering. Doesn't lead to any practical issues, but still incorrect.

Also noticed that the server didn't restart when changing flipper-server-core, or recompile its deps, so fixed that as well.

Reviewed By: passy

Differential Revision: D32644276

fbshipit-source-id: 5384a30c9d293acda04b6e6f940268ddcd65a870
This commit is contained in:
Michel Weststrate
2021-12-08 04:25:28 -08:00
committed by Facebook GitHub Bot
parent 5d45bd741b
commit 9c913151bc
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
desktop/flipper-server-core/src/FlipperServerImpl.tsx
View File

@@ -275,6 +275,7 @@ export class FlipperServerImpl implements FlipperServer {
if (!device) {
return;
}
this.devices.delete(serial);
device.disconnect(); // we'll only destroy upon replacement
this.emit('device-disconnected', device.info);
}

2
desktop/flipper-server/package.json
View File

@@ -32,7 +32,7 @@
"reset": "rimraf lib *.tsbuildinfo",
"build": "tsc -b",
"prepack": "yarn reset && yarn build",
"start": "cross-env NODE_ENV=development nodemon --watch './src/**/*.tsx' --watch '../flipper-server-core/src/**/*.tsx' --exec '../ts-node' src/index.tsx"
"start": "cross-env NODE_ENV=development nodemon --watch './src/**/*.tsx' --watch '../flipper-server-core/src/**/*.tsx' --exec 'yarn build && ../ts-node src/index.tsx'"
},
"files": [
"lib/**/*"