jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the Yogakit change from post install (#1016)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1016

YogaKit's version is compatible recent version of swift and also before the last release its swift version was not mentioned, which caused issues, but now there is no need to set the swift version.

Reviewed By: passy

Differential Revision: D21054723

fbshipit-source-id: 2210cf4beab86088533302028091e0bc44b9d232
This commit is contained in:
Pritesh Nandgaonkar
2020-04-17 07:53:36 -07:00
committed by Facebook GitHub Bot
parent 8addd43f09
commit 9b8974eeb3
4 changed files with 1 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
docs/getting-started/ios-native.md
View File

@@ -48,13 +48,6 @@ target 'MyApp' do
# This post_install hook adds the -DFB_SONARKIT_ENABLED=1 flag to OTHER_CFLAGS, necessary to expose Flipper classes in the header files
post_install do |installer|
installer.pods_project.targets.each do |target|
if target.name == 'YogaKit'
target.build_configurations.each do |config|
config.build_settings['SWIFT_VERSION'] = '4.1'
end
end
end
file_name = Dir.glob("*.xcodeproj")[0]
app_project = Xcodeproj::Project.open(file_name)
app_project.native_targets.each do |target|

7
docs/getting-started/react-native-ios.md
View File

@@ -26,13 +26,6 @@ end
# Post Install processing for Flipper
def flipper_post_install(installer)
installer.pods_project.targets.each do |target|
if target.name == 'YogaKit'
target.build_configurations.each do |config|
config.build_settings['SWIFT_VERSION'] = '4.1'
end
end
end
file_name = Dir.glob("*.xcodeproj")[0]
app_project = Xcodeproj::Project.open(file_name)
app_project.native_targets.each do |target|

7
iOS/Sample/Podfile
View File

@@ -35,13 +35,6 @@ target 'Sample' do
# It also adds -DFB_SONARKIT_ENABLED=1 flag to OTHER_CFLAGS, necessary to build expose Flipper classes in the header files
post_install do |installer|
installer.pods_project.targets.each do |target|
if target.name == 'YogaKit'
target.build_configurations.each do |config|
config.build_settings['SWIFT_VERSION'] = '4.1'
end
end
end
file_name = Dir.glob("*.xcodeproj")[0]
app_project = Xcodeproj::Project.open(file_name)
app_project.native_targets.each do |target|

7
iOS/SampleSwift/Podfile
View File

@@ -33,13 +33,6 @@ target 'SampleSwift' do
# end
post_install do |installer|
installer.pods_project.targets.each do |target|
if target.name == 'YogaKit'
target.build_configurations.each do |config|
config.build_settings['SWIFT_VERSION'] = '4.1'
end
end
end
file_name = Dir.glob("*.xcodeproj")[0]
app_project = Xcodeproj::Project.open(file_name)
app_project.native_targets.each do |target|