From 9b8974eeb3d879d24e0b8cd0a450bcfbf8859ffa Mon Sep 17 00:00:00 2001 From: Pritesh Nandgaonkar Date: Fri, 17 Apr 2020 07:53:36 -0700 Subject: [PATCH] Remove the Yogakit change from post install (#1016) Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/1016 YogaKit's version is compatible recent version of swift and also before the last release its swift version was not mentioned, which caused issues, but now there is no need to set the swift version. Reviewed By: passy Differential Revision: D21054723 fbshipit-source-id: 2210cf4beab86088533302028091e0bc44b9d232 --- docs/getting-started/ios-native.md | 9 +-------- docs/getting-started/react-native-ios.md | 7 ------- iOS/Sample/Podfile | 7 ------- iOS/SampleSwift/Podfile | 7 ------- 4 files changed, 1 insertion(+), 29 deletions(-) diff --git a/docs/getting-started/ios-native.md b/docs/getting-started/ios-native.md index 39bbf42a0..6bf7a14dd 100644 --- a/docs/getting-started/ios-native.md +++ b/docs/getting-started/ios-native.md @@ -48,13 +48,6 @@ target 'MyApp' do # This post_install hook adds the -DFB_SONARKIT_ENABLED=1 flag to OTHER_CFLAGS, necessary to expose Flipper classes in the header files post_install do |installer| - installer.pods_project.targets.each do |target| - if target.name == 'YogaKit' - target.build_configurations.each do |config| - config.build_settings['SWIFT_VERSION'] = '4.1' - end - end - end file_name = Dir.glob("*.xcodeproj")[0] app_project = Xcodeproj::Project.open(file_name) app_project.native_targets.each do |target| @@ -240,4 +233,4 @@ See the [troubleshooting page](../troubleshooting) for help with known problems. On iOS, we currently do not support connecting to physical devices. - \ No newline at end of file + diff --git a/docs/getting-started/react-native-ios.md b/docs/getting-started/react-native-ios.md index 189380190..dda9073a3 100644 --- a/docs/getting-started/react-native-ios.md +++ b/docs/getting-started/react-native-ios.md @@ -26,13 +26,6 @@ end # Post Install processing for Flipper def flipper_post_install(installer) - installer.pods_project.targets.each do |target| - if target.name == 'YogaKit' - target.build_configurations.each do |config| - config.build_settings['SWIFT_VERSION'] = '4.1' - end - end - end file_name = Dir.glob("*.xcodeproj")[0] app_project = Xcodeproj::Project.open(file_name) app_project.native_targets.each do |target| diff --git a/iOS/Sample/Podfile b/iOS/Sample/Podfile index a49cd424f..447179a1d 100644 --- a/iOS/Sample/Podfile +++ b/iOS/Sample/Podfile @@ -35,13 +35,6 @@ target 'Sample' do # It also adds -DFB_SONARKIT_ENABLED=1 flag to OTHER_CFLAGS, necessary to build expose Flipper classes in the header files post_install do |installer| - installer.pods_project.targets.each do |target| - if target.name == 'YogaKit' - target.build_configurations.each do |config| - config.build_settings['SWIFT_VERSION'] = '4.1' - end - end - end file_name = Dir.glob("*.xcodeproj")[0] app_project = Xcodeproj::Project.open(file_name) app_project.native_targets.each do |target| diff --git a/iOS/SampleSwift/Podfile b/iOS/SampleSwift/Podfile index 843ba0e96..b3b3973f2 100644 --- a/iOS/SampleSwift/Podfile +++ b/iOS/SampleSwift/Podfile @@ -33,13 +33,6 @@ target 'SampleSwift' do # end post_install do |installer| - installer.pods_project.targets.each do |target| - if target.name == 'YogaKit' - target.build_configurations.each do |config| - config.build_settings['SWIFT_VERSION'] = '4.1' - end - end - end file_name = Dir.glob("*.xcodeproj")[0] app_project = Xcodeproj::Project.open(file_name) app_project.native_targets.each do |target|