jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove logger dependency

Browse Source 
Summary:
Found that one of the parameters wasn't used for anything making
it harder to make sense of the construct and test it.

Reviewed By: nikoant

Differential Revision: D27117591

fbshipit-source-id: f4c796dd37b0bd75497710fb9f88c923181f90e1
This commit is contained in:
Pascal Hartig
2021-03-18 05:44:10 -07:00
committed by Facebook GitHub Bot
parent 414dd4d5ff
commit 9b44305f1c
2 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
desktop/app/src/fb-stubs/ScribeLogger.tsx
View File

@@ -12,9 +12,7 @@ export type ScribeMessage = {
message: string; message: string;
}; };
import {Logger} from '../fb-interfaces/Logger';
export default class ScribeLogger { export default class ScribeLogger {
constructor(_logger: Logger) {} constructor() {}
send(_message: ScribeMessage) {} send(_message: ScribeMessage) {}
} }

7
desktop/app/src/utils/StubLogger.tsx
View File

@@ -8,15 +8,10 @@
*/ */
import {Logger, Args, TrackType} from '../fb-interfaces/Logger'; import {Logger, Args, TrackType} from '../fb-interfaces/Logger';
import ScribeLogger from '../fb-stubs/ScribeLogger';
import {Store} from '../reducers/index'; import {Store} from '../reducers/index';
export default class StubLogger implements Logger { export default class StubLogger implements Logger {
constructor(_store: Store, _args?: Args) { constructor(_store: Store, _args?: Args) {}
this.scribeLogger = new ScribeLogger(this);
}
scribeLogger: ScribeLogger;
track(_type: TrackType, _event: string, _data?: any, _plugin?: string) {} track(_type: TrackType, _event: string, _data?: any, _plugin?: string) {}