From 9b44305f1c8bf7333e05ede8712206b4ac82409a Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Thu, 18 Mar 2021 05:44:10 -0700 Subject: [PATCH] Remove logger dependency Summary: Found that one of the parameters wasn't used for anything making it harder to make sense of the construct and test it. Reviewed By: nikoant Differential Revision: D27117591 fbshipit-source-id: f4c796dd37b0bd75497710fb9f88c923181f90e1 --- desktop/app/src/fb-stubs/ScribeLogger.tsx | 4 +--- desktop/app/src/utils/StubLogger.tsx | 7 +------ 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/desktop/app/src/fb-stubs/ScribeLogger.tsx b/desktop/app/src/fb-stubs/ScribeLogger.tsx index a3f63cfbc..cb79d1b3a 100644 --- a/desktop/app/src/fb-stubs/ScribeLogger.tsx +++ b/desktop/app/src/fb-stubs/ScribeLogger.tsx @@ -12,9 +12,7 @@ export type ScribeMessage = { message: string; }; -import {Logger} from '../fb-interfaces/Logger'; - export default class ScribeLogger { - constructor(_logger: Logger) {} + constructor() {} send(_message: ScribeMessage) {} } diff --git a/desktop/app/src/utils/StubLogger.tsx b/desktop/app/src/utils/StubLogger.tsx index 9f2d6cd25..19248a0e4 100644 --- a/desktop/app/src/utils/StubLogger.tsx +++ b/desktop/app/src/utils/StubLogger.tsx @@ -8,15 +8,10 @@ */ import {Logger, Args, TrackType} from '../fb-interfaces/Logger'; -import ScribeLogger from '../fb-stubs/ScribeLogger'; import {Store} from '../reducers/index'; export default class StubLogger implements Logger { - constructor(_store: Store, _args?: Args) { - this.scribeLogger = new ScribeLogger(this); - } - - scribeLogger: ScribeLogger; + constructor(_store: Store, _args?: Args) {} track(_type: TrackType, _event: string, _data?: any, _plugin?: string) {}