Change default deviceId for MacOS
Summary: It appears the certificate provider is generating a deviceId which is then sent down to the flipper client to store (under CONNECTION_CONFIG_FILE). For MacOS, this ends up being "unknown". Yet when we attempt to connect to the flipper app, it expects empty string. This diff ensures that for MacOS, we're not sending down "unknown" for the client to store into its config file. Reviewed By: danielbuechele Differential Revision: D17190130 fbshipit-source-id: e0d9825f1f0330a03bcb3cf8d606d5bd9fcc1d7f
This commit is contained in:
committed by
Facebook Github Bot
parent
8fff3fcf59
commit
975af8fa43
@@ -136,6 +136,8 @@ export default class CertificateProvider {
|
||||
return this.getTargetAndroidDeviceId(appName, appDirectory, csr);
|
||||
} else if (os === 'iOS') {
|
||||
return this.getTargetiOSDeviceId(appName, appDirectory, csr);
|
||||
} else if (os == 'MacOS') {
|
||||
return Promise.resolve('');
|
||||
}
|
||||
return Promise.resolve('unknown');
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user