From 975af8fa435af9ed5eebf1727eaf72fb095547a1 Mon Sep 17 00:00:00 2001 From: James Kao Date: Fri, 6 Sep 2019 11:18:05 -0700 Subject: [PATCH] Change default deviceId for MacOS Summary: It appears the certificate provider is generating a deviceId which is then sent down to the flipper client to store (under CONNECTION_CONFIG_FILE). For MacOS, this ends up being "unknown". Yet when we attempt to connect to the flipper app, it expects empty string. This diff ensures that for MacOS, we're not sending down "unknown" for the client to store into its config file. Reviewed By: danielbuechele Differential Revision: D17190130 fbshipit-source-id: e0d9825f1f0330a03bcb3cf8d606d5bd9fcc1d7f --- src/utils/CertificateProvider.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/utils/CertificateProvider.tsx b/src/utils/CertificateProvider.tsx index c54a59f23..94111d5ed 100644 --- a/src/utils/CertificateProvider.tsx +++ b/src/utils/CertificateProvider.tsx @@ -136,6 +136,8 @@ export default class CertificateProvider { return this.getTargetAndroidDeviceId(appName, appDirectory, csr); } else if (os === 'iOS') { return this.getTargetiOSDeviceId(appName, appDirectory, csr); + } else if (os == 'MacOS') { + return Promise.resolve(''); } return Promise.resolve('unknown'); }