jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Potential fix for artefact upload issue

Browse Source 
Summary:
I've been investigating the now persistent upload issue for our artifacts and it appears to come down to artifacts being uploaded and downloaded as folder structures while they used to be individual files.

Annoyingly, the `ghr` tool we use for uploading throws a cryptic and misleading error: https://github.com/facebook/flipper/runs/4314584032?check_suite_focus=true

There is some more control in the `v2` version of the actions but for now, this seems like the safer option to fix this problem.

{F682461661}

Reviewed By: lblasa

Differential Revision: D32649218

fbshipit-source-id: 47ebefc434cb3b928b82a9fe8da3002b7b8465b6
This commit is contained in:
Pascal Hartig
2021-11-24 09:51:44 -08:00
committed by Facebook GitHub Bot
parent 5efc1a9c4b
commit 93bc23e9cd
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/publish-android.yml vendored
View File

@@ -53,7 +53,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with: with:
created_tag: ${{ github.event.inputs.tag }} created_tag: ${{ github.event.inputs.tag }}
args: 'SampleApp-android.apk' args: 'SampleApp-android.apk/SampleApp-android.apk'
- name: Open issue on failure - name: Open issue on failure
if: failure() if: failure()
uses: JasonEtco/create-an-issue@v2.4.0 uses: JasonEtco/create-an-issue@v2.4.0

2
.github/workflows/release.yml vendored
View File

@@ -183,7 +183,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with: with:
created_tag: ${{ needs.release.outputs.tag }} created_tag: ${{ needs.release.outputs.tag }}
args: Flipper-mac.dmg Flipper-linux.zip Flipper-win.zip args: Flipper-mac.dmg/Flipper-mac.dmg Flipper-linux.zip/Flipper-linux.zip Flipper-win.zip/Flipper-win.zip
- name: Open issue on failure - name: Open issue on failure
if: failure() if: failure()
uses: JasonEtco/create-an-issue@v2.4.0 uses: JasonEtco/create-an-issue@v2.4.0