From 93bc23e9cd8e271cf1876d4b20e66dfbfc7c80f1 Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Wed, 24 Nov 2021 09:51:44 -0800 Subject: [PATCH] Potential fix for artefact upload issue Summary: I've been investigating the now persistent upload issue for our artifacts and it appears to come down to artifacts being uploaded and downloaded as folder structures while they used to be individual files. Annoyingly, the `ghr` tool we use for uploading throws a cryptic and misleading error: https://github.com/facebook/flipper/runs/4314584032?check_suite_focus=true There is some more control in the `v2` version of the actions but for now, this seems like the safer option to fix this problem. {F682461661} Reviewed By: lblasa Differential Revision: D32649218 fbshipit-source-id: 47ebefc434cb3b928b82a9fe8da3002b7b8465b6 --- .github/workflows/publish-android.yml | 2 +- .github/workflows/release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-android.yml b/.github/workflows/publish-android.yml index 9bbc9201d..a7ee4cdee 100644 --- a/.github/workflows/publish-android.yml +++ b/.github/workflows/publish-android.yml @@ -53,7 +53,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: created_tag: ${{ github.event.inputs.tag }} - args: 'SampleApp-android.apk' + args: 'SampleApp-android.apk/SampleApp-android.apk' - name: Open issue on failure if: failure() uses: JasonEtco/create-an-issue@v2.4.0 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 00975ec60..4eb519b26 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -183,7 +183,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: created_tag: ${{ needs.release.outputs.tag }} - args: Flipper-mac.dmg Flipper-linux.zip Flipper-win.zip + args: Flipper-mac.dmg/Flipper-mac.dmg Flipper-linux.zip/Flipper-linux.zip Flipper-win.zip/Flipper-win.zip - name: Open issue on failure if: failure() uses: JasonEtco/create-an-issue@v2.4.0