jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Hide unknown value processing behind a GK

Browse Source 
Reviewed By: antonk52

Differential Revision: D49822509

fbshipit-source-id: 2228883f8ef16013a63c0d6d69697e32b55cec68
This commit is contained in:
Andrey Goncharov
2023-10-02 08:27:37 -07:00
committed by Facebook GitHub Bot
parent 76918ae4fe
commit 84bb47655e
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
desktop/flipper-plugin/src/ui/data-table/DataTableDefaultPowerSearchOperators.tsx
View File

@@ -8,6 +8,7 @@
*/ */
import dayjs from 'dayjs'; import dayjs from 'dayjs';
import {getFlipperLib} from 'flipper-plugin-core';
import {OperatorConfig} from '../PowerSearch'; import {OperatorConfig} from '../PowerSearch';
import { import {
FloatOperatorConfig, FloatOperatorConfig,
@@ -214,7 +215,8 @@ const tryConvertingUnknownToString = (value: unknown): string | null => {
export const dataTablePowerSearchOperatorProcessorConfig = { export const dataTablePowerSearchOperatorProcessorConfig = {
string_contains: (operator, searchValue: string, value: string) => string_contains: (operator, searchValue: string, value: string) =>
!!( !!(
(operator as StringOperatorConfig).handleUnknownValues (operator as StringOperatorConfig).handleUnknownValues &&
getFlipperLib().GK('flipper_power_search_auto_json_stringify')
? tryConvertingUnknownToString(value) ? tryConvertingUnknownToString(value)
: value : value
) )
@@ -222,18 +224,21 @@ export const dataTablePowerSearchOperatorProcessorConfig = {
.includes(searchValue.toLowerCase()), .includes(searchValue.toLowerCase()),
string_not_contains: (operator, searchValue: string, value: string) => string_not_contains: (operator, searchValue: string, value: string) =>
!( !(
(operator as StringOperatorConfig).handleUnknownValues (operator as StringOperatorConfig).handleUnknownValues &&
getFlipperLib().GK('flipper_power_search_auto_json_stringify')
? tryConvertingUnknownToString(value) ? tryConvertingUnknownToString(value)
: value : value
) )
?.toLowerCase() ?.toLowerCase()
.includes(searchValue.toLowerCase()), .includes(searchValue.toLowerCase()),
string_matches_exactly: (operator, searchValue: string, value: string) => string_matches_exactly: (operator, searchValue: string, value: string) =>
((operator as StringOperatorConfig).handleUnknownValues ((operator as StringOperatorConfig).handleUnknownValues &&
getFlipperLib().GK('flipper_power_search_auto_json_stringify')
? tryConvertingUnknownToString(value) ? tryConvertingUnknownToString(value)
: value) === searchValue, : value) === searchValue,
string_not_matches_exactly: (operator, searchValue: string, value: string) => string_not_matches_exactly: (operator, searchValue: string, value: string) =>
((operator as StringOperatorConfig).handleUnknownValues ((operator as StringOperatorConfig).handleUnknownValues &&
getFlipperLib().GK('flipper_power_search_auto_json_stringify')
? tryConvertingUnknownToString(value) ? tryConvertingUnknownToString(value)
: value) !== searchValue, : value) !== searchValue,
// See PowerSearchStringSetTerm // See PowerSearchStringSetTerm