From 84bb47655e0c9325d6c805e964bc0d6377455853 Mon Sep 17 00:00:00 2001 From: Andrey Goncharov Date: Mon, 2 Oct 2023 08:27:37 -0700 Subject: [PATCH] Hide unknown value processing behind a GK Reviewed By: antonk52 Differential Revision: D49822509 fbshipit-source-id: 2228883f8ef16013a63c0d6d69697e32b55cec68 --- .../DataTableDefaultPowerSearchOperators.tsx | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/desktop/flipper-plugin/src/ui/data-table/DataTableDefaultPowerSearchOperators.tsx b/desktop/flipper-plugin/src/ui/data-table/DataTableDefaultPowerSearchOperators.tsx index 825e897a2..e7760b343 100644 --- a/desktop/flipper-plugin/src/ui/data-table/DataTableDefaultPowerSearchOperators.tsx +++ b/desktop/flipper-plugin/src/ui/data-table/DataTableDefaultPowerSearchOperators.tsx @@ -8,6 +8,7 @@ */ import dayjs from 'dayjs'; +import {getFlipperLib} from 'flipper-plugin-core'; import {OperatorConfig} from '../PowerSearch'; import { FloatOperatorConfig, @@ -214,7 +215,8 @@ const tryConvertingUnknownToString = (value: unknown): string | null => { export const dataTablePowerSearchOperatorProcessorConfig = { string_contains: (operator, searchValue: string, value: string) => !!( - (operator as StringOperatorConfig).handleUnknownValues + (operator as StringOperatorConfig).handleUnknownValues && + getFlipperLib().GK('flipper_power_search_auto_json_stringify') ? tryConvertingUnknownToString(value) : value ) @@ -222,18 +224,21 @@ export const dataTablePowerSearchOperatorProcessorConfig = { .includes(searchValue.toLowerCase()), string_not_contains: (operator, searchValue: string, value: string) => !( - (operator as StringOperatorConfig).handleUnknownValues + (operator as StringOperatorConfig).handleUnknownValues && + getFlipperLib().GK('flipper_power_search_auto_json_stringify') ? tryConvertingUnknownToString(value) : value ) ?.toLowerCase() .includes(searchValue.toLowerCase()), string_matches_exactly: (operator, searchValue: string, value: string) => - ((operator as StringOperatorConfig).handleUnknownValues + ((operator as StringOperatorConfig).handleUnknownValues && + getFlipperLib().GK('flipper_power_search_auto_json_stringify') ? tryConvertingUnknownToString(value) : value) === searchValue, string_not_matches_exactly: (operator, searchValue: string, value: string) => - ((operator as StringOperatorConfig).handleUnknownValues + ((operator as StringOperatorConfig).handleUnknownValues && + getFlipperLib().GK('flipper_power_search_auto_json_stringify') ? tryConvertingUnknownToString(value) : value) !== searchValue, // See PowerSearchStringSetTerm