Fix some react warnings

Summary: React is printing errors saying not to use "Span", and booleans in html properties

Reviewed By: danielbuechele

Differential Revision: D15535593

fbshipit-source-id: e074137c89abfa69625b370087c9c18b579ff279
This commit is contained in:
John Knox
2019-05-30 03:12:38 -07:00
committed by Facebook Github Bot
parent 8c4e373dfc
commit 79902cd7cb
3 changed files with 8 additions and 6 deletions

View File

@@ -31,7 +31,7 @@ import _ from 'lodash';
const PAGE_SIZE = 50; const PAGE_SIZE = 50;
const BoldSpan = styled('Span')({ const BoldSpan = styled('span')({
fontSize: 12, fontSize: 12,
color: '#90949c', color: '#90949c',
fontWeight: 'bold', fontWeight: 'bold',
@@ -707,7 +707,7 @@ export default class DatabasesPlugin extends FlipperPlugin<
selected={this.state.selectedDatabaseTable} selected={this.state.selectedDatabaseTable}
onChange={this.onDatabaseTableSelected} onChange={this.onDatabaseTableSelected}
/> />
<div grow={true} /> <div />
<Button onClick={this.onRefreshClicked}>Refresh</Button> <Button onClick={this.onRefreshClicked}>Refresh</Button>
<Button style={{marginLeft: 'auto', display: 'none'}}> <Button style={{marginLeft: 'auto', display: 'none'}}>
Execute SQL Execute SQL

View File

@@ -57,8 +57,10 @@ export default class Select extends Component<{
id={this.selectID} id={this.selectID}
onChange={this.onChange} onChange={this.onChange}
className={className}> className={className}>
{Object.keys(options).map(key => ( {Object.keys(options).map((key, index) => (
<option selected={key === selected}>{options[key]}</option> <option key={index} selected={key === selected}>
{options[key]}
</option>
))} ))}
</SelectMenu> </SelectMenu>
); );

View File

@@ -140,7 +140,7 @@ type ManagedTableState = {|
|}; |};
const Container = styled(FlexColumn)(props => ({ const Container = styled(FlexColumn)(props => ({
overflow: props.overflow ? 'scroll' : 'visible', overflow: props.canOverflow ? 'scroll' : 'visible',
flexGrow: 1, flexGrow: 1,
})); }));
@@ -617,7 +617,7 @@ class ManagedTable extends React.Component<
} }
return ( return (
<Container overflow={horizontallyScrollable}> <Container canOverflow={horizontallyScrollable}>
{hideHeader !== true && ( {hideHeader !== true && (
<TableHead <TableHead
columnOrder={columnOrder} columnOrder={columnOrder}