From 79902cd7cb4a9b8e6f641125d71b4bdc65ccd776 Mon Sep 17 00:00:00 2001
From: John Knox <jknox@fb.com>
Date: Thu, 30 May 2019 03:12:38 -0700
Subject: [PATCH] Fix some react warnings

Summary: React is printing errors saying not to use "Span", and booleans in html properties

Reviewed By: danielbuechele

Differential Revision: D15535593

fbshipit-source-id: e074137c89abfa69625b370087c9c18b579ff279
---
 src/plugins/databases/index.js          | 4 ++--
 src/ui/components/Select.js             | 6 ++++--
 src/ui/components/table/ManagedTable.js | 4 ++--
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/plugins/databases/index.js b/src/plugins/databases/index.js
index aa424d5fd..661f29ac3 100644
--- a/src/plugins/databases/index.js
+++ b/src/plugins/databases/index.js
@@ -31,7 +31,7 @@ import _ from 'lodash';
 
 const PAGE_SIZE = 50;
 
-const BoldSpan = styled('Span')({
+const BoldSpan = styled('span')({
   fontSize: 12,
   color: '#90949c',
   fontWeight: 'bold',
@@ -707,7 +707,7 @@ export default class DatabasesPlugin extends FlipperPlugin<
             selected={this.state.selectedDatabaseTable}
             onChange={this.onDatabaseTableSelected}
           />
-          <div grow={true} />
+          <div />
           <Button onClick={this.onRefreshClicked}>Refresh</Button>
           <Button style={{marginLeft: 'auto', display: 'none'}}>
             Execute SQL
diff --git a/src/ui/components/Select.js b/src/ui/components/Select.js
index 9f6ded32c..361e70372 100644
--- a/src/ui/components/Select.js
+++ b/src/ui/components/Select.js
@@ -57,8 +57,10 @@ export default class Select extends Component<{
         id={this.selectID}
         onChange={this.onChange}
         className={className}>
-        {Object.keys(options).map(key => (
-          <option selected={key === selected}>{options[key]}</option>
+        {Object.keys(options).map((key, index) => (
+          <option key={index} selected={key === selected}>
+            {options[key]}
+          </option>
         ))}
       </SelectMenu>
     );
diff --git a/src/ui/components/table/ManagedTable.js b/src/ui/components/table/ManagedTable.js
index 2219ba11b..5c4b8692a 100644
--- a/src/ui/components/table/ManagedTable.js
+++ b/src/ui/components/table/ManagedTable.js
@@ -140,7 +140,7 @@ type ManagedTableState = {|
 |};
 
 const Container = styled(FlexColumn)(props => ({
-  overflow: props.overflow ? 'scroll' : 'visible',
+  overflow: props.canOverflow ? 'scroll' : 'visible',
   flexGrow: 1,
 }));
 
@@ -617,7 +617,7 @@ class ManagedTable extends React.Component<
     }
 
     return (
-      <Container overflow={horizontallyScrollable}>
+      <Container canOverflow={horizontallyScrollable}>
         {hideHeader !== true && (
           <TableHead
             columnOrder={columnOrder}