jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cleanup 1/n

Browse Source 
Summary:
Making some changes to make this more idiomatic and abide by
the Flipper/FB standards. This one just removes some unused
variables and annotations.

Reviewed By: jknoxville

Differential Revision: D19470676

fbshipit-source-id: 4beb516f00228b1d33e4e1b42d9bc4f8c29af565
This commit is contained in:
Pascal Hartig
2020-01-24 05:00:18 -08:00
committed by Facebook Github Bot
parent 0812568be1
commit 6864556912
3 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperPackage.java
View File

@@ -20,8 +20,6 @@ import java.util.List;
* application context lives shorter than the application itself, e.g. reload creates a fresh one. * application context lives shorter than the application itself, e.g. reload creates a fresh one.
*/ */
public class FlipperPackage implements ReactPackage { public class FlipperPackage implements ReactPackage {
static FlipperModule flipperModule;
@Override @Override
public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) { public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
return Arrays.<NativeModule>asList( return Arrays.<NativeModule>asList(

2
react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperReactNativeJavaScriptPlugin.java
View File

@@ -58,7 +58,7 @@ public abstract class FlipperReactNativeJavaScriptPlugin implements FlipperPlugi
} }
@Override @Override
public void onDisconnect() throws Exception { public void onDisconnect() {
this.module.sendJSEvent("react-native-flipper-plugin-disconnect", getPluginParams()); this.module.sendJSEvent("react-native-flipper-plugin-disconnect", getPluginParams());
this.connection = null; this.connection = null;
} }

2
react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperReactNativeJavaScriptReceiver.java
View File

@@ -31,7 +31,7 @@ public class FlipperReactNativeJavaScriptReceiver implements FlipperReceiver {
} }
@Override @Override
public void onReceive(FlipperObject params, FlipperResponder responder) throws Exception { public void onReceive(FlipperObject params, FlipperResponder responder) {
WritableMap eventData = Arguments.createMap(); WritableMap eventData = Arguments.createMap();
eventData.putString("plugin", plugin); eventData.putString("plugin", plugin);
eventData.putString("method", method); eventData.putString("method", method);