From 68645569126faac3ce5158ff6ebe5ee1107c99dc Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Fri, 24 Jan 2020 05:00:18 -0800 Subject: [PATCH] Cleanup 1/n Summary: Making some changes to make this more idiomatic and abide by the Flipper/FB standards. This one just removes some unused variables and annotations. Reviewed By: jknoxville Differential Revision: D19470676 fbshipit-source-id: 4beb516f00228b1d33e4e1b42d9bc4f8c29af565 --- .../java/com/facebook/flipper/reactnative/FlipperPackage.java | 2 -- .../flipper/reactnative/FlipperReactNativeJavaScriptPlugin.java | 2 +- .../reactnative/FlipperReactNativeJavaScriptReceiver.java | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperPackage.java b/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperPackage.java index ffa8ba16a..48f108a70 100644 --- a/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperPackage.java +++ b/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperPackage.java @@ -20,8 +20,6 @@ import java.util.List; * application context lives shorter than the application itself, e.g. reload creates a fresh one. */ public class FlipperPackage implements ReactPackage { - static FlipperModule flipperModule; - @Override public List createNativeModules(ReactApplicationContext reactContext) { return Arrays.asList( diff --git a/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperReactNativeJavaScriptPlugin.java b/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperReactNativeJavaScriptPlugin.java index 175adc8a3..33645da6d 100644 --- a/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperReactNativeJavaScriptPlugin.java +++ b/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperReactNativeJavaScriptPlugin.java @@ -58,7 +58,7 @@ public abstract class FlipperReactNativeJavaScriptPlugin implements FlipperPlugi } @Override - public void onDisconnect() throws Exception { + public void onDisconnect() { this.module.sendJSEvent("react-native-flipper-plugin-disconnect", getPluginParams()); this.connection = null; } diff --git a/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperReactNativeJavaScriptReceiver.java b/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperReactNativeJavaScriptReceiver.java index 083d50ce1..4f4e2af72 100644 --- a/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperReactNativeJavaScriptReceiver.java +++ b/react-native/react-native-flipper/android/src/main/java/com/facebook/flipper/reactnative/FlipperReactNativeJavaScriptReceiver.java @@ -31,7 +31,7 @@ public class FlipperReactNativeJavaScriptReceiver implements FlipperReceiver { } @Override - public void onReceive(FlipperObject params, FlipperResponder responder) throws Exception { + public void onReceive(FlipperObject params, FlipperResponder responder) { WritableMap eventData = Arguments.createMap(); eventData.putString("plugin", plugin); eventData.putString("method", method);