Enabling fullscreen mode on macos (#259)
Summary: I wanted to use Flipper/Sonar in a fullscreen/split screen environment end was surprised the feature was disabled. When I checked the blame it looks like it's been like this from the get go, so there might not even be a real reason to have it disabled. Please correct me if I'm wrong. The default value for `fullsreenable` is true. Removing setting the parameter reenables the feature. - Flipped the switch, saw it go fullscreen - Also works in split screens Pull Request resolved: https://github.com/facebook/flipper/pull/259 Reviewed By: danielbuechele Differential Revision: D9630068 Pulled By: passy fbshipit-source-id: 650e54895dc596090e2edcf2802bb0020f207ecc
This commit is contained in:
committed by
Facebook Github Bot
parent
dc05fde28d
commit
661d5a8f5b
@@ -161,7 +161,6 @@ function tryCreateWindow() {
|
|||||||
minWidth: 800,
|
minWidth: 800,
|
||||||
minHeight: 600,
|
minHeight: 600,
|
||||||
center: true,
|
center: true,
|
||||||
fullscreenable: false,
|
|
||||||
backgroundThrottling: false,
|
backgroundThrottling: false,
|
||||||
titleBarStyle: 'hiddenInset',
|
titleBarStyle: 'hiddenInset',
|
||||||
vibrancy: 'sidebar',
|
vibrancy: 'sidebar',
|
||||||
|
|||||||
Reference in New Issue
Block a user