From 661d5a8f5bceba46f42e6a59b3abbb16b0c86a45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ullrich=20Sch=C3=A4fer?= Date: Mon, 3 Sep 2018 07:51:59 -0700 Subject: [PATCH] Enabling fullscreen mode on macos (#259) Summary: I wanted to use Flipper/Sonar in a fullscreen/split screen environment end was surprised the feature was disabled. When I checked the blame it looks like it's been like this from the get go, so there might not even be a real reason to have it disabled. Please correct me if I'm wrong. The default value for `fullsreenable` is true. Removing setting the parameter reenables the feature. - Flipped the switch, saw it go fullscreen - Also works in split screens Pull Request resolved: https://github.com/facebook/flipper/pull/259 Reviewed By: danielbuechele Differential Revision: D9630068 Pulled By: passy fbshipit-source-id: 650e54895dc596090e2edcf2802bb0020f207ecc --- static/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/static/index.js b/static/index.js index 111dbd9f3..9f18ea279 100644 --- a/static/index.js +++ b/static/index.js @@ -161,7 +161,6 @@ function tryCreateWindow() { minWidth: 800, minHeight: 600, center: true, - fullscreenable: false, backgroundThrottling: false, titleBarStyle: 'hiddenInset', vibrancy: 'sidebar',