jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix CFBundleVersion

Browse Source 
Summary:
This defaults to the `version` and is used to update the inline plists
of the Frameworks that are bundled with the MacOS app bundle. Setting
them to a fixed value means that they remain unchanged across rebuilds
(bringing them in line with Linux and Windows equivalents). This
is required to ship them as separate bundles for the launcher.

Why 50? The reason this was introduced was to allow people to override
this to values >= 50 as this is somehow a Mac App Store requirement:
https://github.com/electron-userland/electron-builder/issues/565#issuecomment-230678643

Reviewed By: priteshrnandgaonkar

Differential Revision: D21179072

fbshipit-source-id: a6f10b7508526b4305b229bd160d6e570ddce822
This commit is contained in:
Pascal Hartig
2020-04-23 01:47:41 -07:00
committed by Facebook GitHub Bot
parent 1509180929
commit 65f935efab
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
desktop/scripts/build-release.ts
View File

@@ -115,6 +115,9 @@ async function buildDist(buildFolder: string) {
linux: { linux: {
executableName: 'flipper', executableName: 'flipper',
}, },
mac: {
bundleVersion: '50.0.0',
},
}, },
projectDir: buildFolder, projectDir: buildFolder,
targets, targets,