From 65f935efab7dfe13c5449da99c9410c3e5d02620 Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Thu, 23 Apr 2020 01:47:41 -0700 Subject: [PATCH] Fix CFBundleVersion Summary: This defaults to the `version` and is used to update the inline plists of the Frameworks that are bundled with the MacOS app bundle. Setting them to a fixed value means that they remain unchanged across rebuilds (bringing them in line with Linux and Windows equivalents). This is required to ship them as separate bundles for the launcher. Why 50? The reason this was introduced was to allow people to override this to values >= 50 as this is somehow a Mac App Store requirement: https://github.com/electron-userland/electron-builder/issues/565#issuecomment-230678643 Reviewed By: priteshrnandgaonkar Differential Revision: D21179072 fbshipit-source-id: a6f10b7508526b4305b229bd160d6e570ddce822 --- desktop/scripts/build-release.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/desktop/scripts/build-release.ts b/desktop/scripts/build-release.ts index fa4624fe7..b6b67dcb6 100755 --- a/desktop/scripts/build-release.ts +++ b/desktop/scripts/build-release.ts @@ -115,6 +115,9 @@ async function buildDist(buildFolder: string) { linux: { executableName: 'flipper', }, + mac: { + bundleVersion: '50.0.0', + }, }, projectDir: buildFolder, targets,