jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stop failing the entire plugin compatibility check if a shared plugin lib fails it

Browse Source 
Summary: Currently, if we publish a new shared plugin lib in a separate diff, the compatibility check fails for it while it should exit with a warning only

Reviewed By: antonk52

Differential Revision: D39731259

fbshipit-source-id: 7651642ebfb5e18ace047d36b52907bca65c4462
This commit is contained in:
Andrey Goncharov
2022-09-23 04:52:42 -07:00
committed by Facebook GitHub Bot
parent b43d8f5c80
commit 61a8fe09e9
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
desktop/scripts/tsc-plugins.tsx
View File

@@ -109,9 +109,6 @@ async function findAffectedPlugins(errors: string[]) {
depsByName.set(name, getDependencies(name)); depsByName.set(name, getDependencies(name));
} }
for (const pkg of allPackages) { for (const pkg of allPackages) {
if (!isPluginJson(pkg.json)) {
continue;
}
const logFile = path.join(pkg.dir, 'tsc-error.log'); const logFile = path.join(pkg.dir, 'tsc-error.log');
await fs.remove(logFile); await fs.remove(logFile);
let logStream: fs.WriteStream | undefined; let logStream: fs.WriteStream | undefined;