From 61a8fe09e951b1facf96eb4766fa13c38585f90d Mon Sep 17 00:00:00 2001 From: Andrey Goncharov Date: Fri, 23 Sep 2022 04:52:42 -0700 Subject: [PATCH] Stop failing the entire plugin compatibility check if a shared plugin lib fails it Summary: Currently, if we publish a new shared plugin lib in a separate diff, the compatibility check fails for it while it should exit with a warning only Reviewed By: antonk52 Differential Revision: D39731259 fbshipit-source-id: 7651642ebfb5e18ace047d36b52907bca65c4462 --- desktop/scripts/tsc-plugins.tsx | 3 --- 1 file changed, 3 deletions(-) diff --git a/desktop/scripts/tsc-plugins.tsx b/desktop/scripts/tsc-plugins.tsx index 11ab305c6..28912149b 100644 --- a/desktop/scripts/tsc-plugins.tsx +++ b/desktop/scripts/tsc-plugins.tsx @@ -109,9 +109,6 @@ async function findAffectedPlugins(errors: string[]) { depsByName.set(name, getDependencies(name)); } for (const pkg of allPackages) { - if (!isPluginJson(pkg.json)) { - continue; - } const logFile = path.join(pkg.dir, 'tsc-error.log'); await fs.remove(logFile); let logStream: fs.WriteStream | undefined;