jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Plugin download failure is not an error

Browse Source 
Summary: Plugin download failure is typical a transient error, no need to trigger monitoring for that

Reviewed By: ivanmisuno

Differential Revision: D43118116

fbshipit-source-id: 0cd0f87f0ed6123adcba28139308ecea92b1b508
This commit is contained in:
Michel Weststrate
2023-02-10 02:22:50 -08:00
committed by Facebook GitHub Bot
parent 9bc9b53017
commit 6196204a7b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/flipper-server-core/src/plugins/PluginManager.tsx
View File

@@ -185,7 +185,7 @@ export class PluginManager {
return await installPluginFromFile(tmpFile); return await installPluginFromFile(tmpFile);
} }
} catch (error) { } catch (error) {
console.error( console.warn(
`Failed to download plugin "${title}" v${version} from "${downloadUrl}" to "${installationDir}".`, `Failed to download plugin "${title}" v${version} from "${downloadUrl}" to "${installationDir}".`,
error, error,
); );

2
desktop/flipper-ui-core/src/dispatcher/pluginDownloads.tsx
View File

@@ -83,7 +83,7 @@ async function handlePluginDownload(
`Successfully downloaded and installed plugin "${title}" v${version} from "${downloadUrl}".`, `Successfully downloaded and installed plugin "${title}" v${version} from "${downloadUrl}".`,
); );
} catch (error) { } catch (error) {
console.error( console.warn(
`Failed to download plugin "${title}" v${version} from "${downloadUrl}".`, `Failed to download plugin "${title}" v${version} from "${downloadUrl}".`,
error, error,
); );