From 6196204a7b72f97968668de5cc7357f71e15308c Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Fri, 10 Feb 2023 02:22:50 -0800 Subject: [PATCH] Plugin download failure is not an error Summary: Plugin download failure is typical a transient error, no need to trigger monitoring for that Reviewed By: ivanmisuno Differential Revision: D43118116 fbshipit-source-id: 0cd0f87f0ed6123adcba28139308ecea92b1b508 --- desktop/flipper-server-core/src/plugins/PluginManager.tsx | 2 +- desktop/flipper-ui-core/src/dispatcher/pluginDownloads.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/desktop/flipper-server-core/src/plugins/PluginManager.tsx b/desktop/flipper-server-core/src/plugins/PluginManager.tsx index ac12b5ba5..23ee8d606 100644 --- a/desktop/flipper-server-core/src/plugins/PluginManager.tsx +++ b/desktop/flipper-server-core/src/plugins/PluginManager.tsx @@ -185,7 +185,7 @@ export class PluginManager { return await installPluginFromFile(tmpFile); } } catch (error) { - console.error( + console.warn( `Failed to download plugin "${title}" v${version} from "${downloadUrl}" to "${installationDir}".`, error, ); diff --git a/desktop/flipper-ui-core/src/dispatcher/pluginDownloads.tsx b/desktop/flipper-ui-core/src/dispatcher/pluginDownloads.tsx index 8c71f71f7..af3397dc2 100644 --- a/desktop/flipper-ui-core/src/dispatcher/pluginDownloads.tsx +++ b/desktop/flipper-ui-core/src/dispatcher/pluginDownloads.tsx @@ -83,7 +83,7 @@ async function handlePluginDownload( `Successfully downloaded and installed plugin "${title}" v${version} from "${downloadUrl}".`, ); } catch (error) { - console.error( + console.warn( `Failed to download plugin "${title}" v${version} from "${downloadUrl}".`, error, );