Fix Flipper lints #17

Summary: Mostly disabling warnings for scripts which are fine to use `console.error` directly.

Reviewed By: timur-valiev

Differential Revision: D30812956

fbshipit-source-id: 7fdc5bdf08f72d0d849ece6a4194d6a115d693f0

desktop/scripts/build-plugin.ts

@@ -15,6 +15,7 @@ import {runBuild, computePackageChecksum} from 'flipper-pkg-lib';
 import yargs from 'yargs';
 import tmp from 'tmp';
 import {execSync} from 'child_process';
+import {promisify} from 'util';
 
 const argv = yargs
   .usage('yarn build-plugin [args]')
@@ -89,7 +90,7 @@ async function buildPlugin() {
       : path.join(distDir, 'plugins', path.relative(pluginsDir, pluginDir));
     await fs.ensureDir(path.dirname(outputFile));
     await fs.remove(outputFile);
-    const {name: tmpDir} = tmp.dirSync();
+    const tmpDir = await promisify(tmp.dir)();
     const packageJsonBackupPath = path.join(tmpDir, 'package.json');
     await fs.copy(packageJsonPath, packageJsonBackupPath, {overwrite: true});
     try {

desktop/scripts/bump-versions.ts

@@ -7,6 +7,8 @@
  * @format
  */
 
+/* eslint-disable flipper/no-console-error-without-context */
+
 import {bumpVersions} from './workspaces';
 import yargs from 'yargs';
 

desktop/scripts/compute-package-checksum.ts

@@ -7,6 +7,8 @@
  * @format
  */
 
+/* eslint-disable flipper/no-console-error-without-context */
+
 import {computePackageChecksum} from 'flipper-pkg-lib';
 import yargs from 'yargs';
 

desktop/scripts/gen-type-index.ts

@@ -6,6 +6,7 @@
  *
  * @format
  */
+/* eslint-disable flipper/no-console-error-without-context */
 
 import {rootDir} from './paths';
 import path from 'path';

desktop/scripts/generate-plugin-entry-points.ts

@@ -7,6 +7,8 @@
  * @format
  */
 
+/* eslint-disable flipper/no-console-error-without-context */
+
 import {prepareDefaultPlugins} from './build-utils';
 
 prepareDefaultPlugins().catch((err) => {

desktop/scripts/get-app-watch-folders.ts

@@ -35,5 +35,5 @@ export default async function getAppWatchFolders() {
   }
   return watchFolders
     .filter((value, index, self) => self.indexOf(value) === index)
-    .filter(fs.pathExistsSync);
+    .filter(async (f) => fs.pathExists(f));
 }

desktop/scripts/isFB.js

@@ -11,6 +11,8 @@
 const fs = require('fs-extra');
 const path = require('path');
 
+// Only used once at startup.
+// eslint-disable-next-line node/no-sync
 const isFB = fs.pathExistsSync(path.resolve(__dirname, '..', 'static', 'fb'));
 
 module.exports = isFB;

desktop/scripts/list-plugins.ts

@@ -7,6 +7,8 @@
  * @format
  */
 
+/* eslint-disable flipper/no-console-error-without-context */
+
 import {getWorkspaces} from './workspaces';
 
 getWorkspaces()

desktop/scripts/publish-packages.ts

@@ -7,6 +7,8 @@
  * @format
  */
 
+/* eslint-disable flipper/no-console-error-without-context */
+
 import {publishPackages} from './workspaces';
 import yargs from 'yargs';
 

desktop/scripts/resolve-plugin-dir.ts

@@ -7,6 +7,8 @@
  * @format
  */
 
+/* eslint-disable flipper/no-console-error-without-context */
+
 import {resolvePluginDir} from './workspaces';
 
 resolvePluginDir(process.argv[2])

desktop/scripts/start-dev-server.ts

@@ -383,6 +383,8 @@ function buildErrorScreen() {
       lines.push(err.message);
       lines.push(
         codeFrame(
+          // Part of a script, not blocking the UI loop.
+          // eslint-disable-next-line node/no-sync
           fs.readFileSync(err.filename, 'utf8'),
           err.lineNumber,
           err.column,

desktop/scripts/tsc-plugins.ts

@@ -7,6 +7,8 @@
  * @format
  */
 
+/* eslint-disable flipper/no-console-error-without-context */
+
 import fs from 'fs-extra';
 import path from 'path';
 import {exec} from 'child_process';